Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: src/debug/debug.cc

Issue 1762323002: [compiler] Move ClearExceptionFlag into Compiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: More places. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.h ('k') | src/globals.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1506 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 // Ensures the debug information is present for shared. 1517 // Ensures the debug information is present for shared.
1518 bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared, 1518 bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared,
1519 Handle<JSFunction> function) { 1519 Handle<JSFunction> function) {
1520 if (!shared->IsSubjectToDebugging()) return false; 1520 if (!shared->IsSubjectToDebugging()) return false;
1521 1521
1522 // Return if we already have the debug info for shared. 1522 // Return if we already have the debug info for shared.
1523 if (shared->HasDebugInfo()) return true; 1523 if (shared->HasDebugInfo()) return true;
1524 1524
1525 if (function.is_null()) { 1525 if (function.is_null()) {
1526 DCHECK(shared->HasDebugCode()); 1526 DCHECK(shared->HasDebugCode());
1527 } else if (!Compiler::Compile(function, CLEAR_EXCEPTION)) { 1527 } else if (!Compiler::Compile(function, Compiler::CLEAR_EXCEPTION)) {
1528 return false; 1528 return false;
1529 } 1529 }
1530 1530
1531 if (shared->HasBytecodeArray()) { 1531 if (shared->HasBytecodeArray()) {
1532 // To prepare bytecode for debugging, we already need to have the debug 1532 // To prepare bytecode for debugging, we already need to have the debug
1533 // info (containing the debug copy) upfront, but since we do not recompile, 1533 // info (containing the debug copy) upfront, but since we do not recompile,
1534 // preparing for break points cannot fail. 1534 // preparing for break points cannot fail.
1535 CreateDebugInfo(shared); 1535 CreateDebugInfo(shared);
1536 CHECK(PrepareFunctionForBreakPoints(shared)); 1536 CHECK(PrepareFunctionForBreakPoints(shared));
1537 } else { 1537 } else {
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
2668 } 2668 }
2669 2669
2670 2670
2671 void LockingCommandMessageQueue::Clear() { 2671 void LockingCommandMessageQueue::Clear() {
2672 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2672 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2673 queue_.Clear(); 2673 queue_.Clear();
2674 } 2674 }
2675 2675
2676 } // namespace internal 2676 } // namespace internal
2677 } // namespace v8 2677 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.h ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698