[compiler] Unify naming of methods in compiler API.

[compiler] Unify naming of methods in compiler API.

This is a pure refactoring and renaming of methods in the compiler API
with the goal to increase readability. Also the compiler API is moved to
the top of the file, as it is the central piece in that file.

R=yangguo@chromium.org

Committed: https://crrev.com/46bd989a3ab32efc8f8c6fdcbf7ac832c53c65d7
Cr-Commit-Position: refs/heads/master@{#34579}

[Yang, 2016-03-07 06:01:08]

lgtm. Some comments on comments. Metacomments.

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h#newcode31
src/compiler.h:31: // General strategy: Source code is translated into an
anonymous function w/o
I'd prefer "script source code" to be clear that this doesn't refer to inner
functions.

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h#newcode50
src/compiler.h:50: static void CompileForLiveEdit(Handle<Script> script);
Comment does not really apply to this one. CompileForLiveEdit eagerly compiles
the entire script, for the purpose of LiveEdit.

[Michael Starzinger, 2016-03-08 10:23:24]

PTAL. Addressed and meta-addressed the meta-comments. :)

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h
File src/compiler.h (right):

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h#newcode31
src/compiler.h:31: // General strategy: Source code is translated into an
anonymous function w/o
On 2016/03/07 06:01:08, Yang wrote:
> I'd prefer "script source code" to be clear that this doesn't refer to inner
> functions.

Done.

https://codereview.chromium.org/1766623004/diff/40001/src/compiler.h#newcode50
src/compiler.h:50: static void CompileForLiveEdit(Handle<Script> script);
On 2016/03/07 06:01:08, Yang wrote:
> Comment does not really apply to this one. CompileForLiveEdit eagerly compiles
> the entire script, for the purpose of LiveEdit.

Done. Added a remark as discussed offline.

[Yang, 2016-03-08 12:04:47]

lgtm

[Michael Starzinger, 2016-03-08 12:06:04]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-03-08 12:06:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1766623004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1766623004/80001

[commit-bot: I haz the power, 2016-03-08 12:07:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-08 12:09:17]

Description was changed from

==========
[compiler] Unify naming of methods in compiler API.

This is a pure refactoring and renaming of methods in the compiler API
with the goal to increase readability. Also the compiler API is moved to
the top of the file, as it is the central piece in that file.

R=yangguo@chromium.org
==========

to

==========
[compiler] Unify naming of methods in compiler API.

This is a pure refactoring and renaming of methods in the compiler API
with the goal to increase readability. Also the compiler API is moved to
the top of the file, as it is the central piece in that file.

R=yangguo@chromium.org

Committed: https://crrev.com/46bd989a3ab32efc8f8c6fdcbf7ac832c53c65d7
Cr-Commit-Position: refs/heads/master@{#34579}
==========

[commit-bot: I haz the power, 2016-03-08 12:09:18]

Patchset 5 (id:??) landed as
https://crrev.com/46bd989a3ab32efc8f8c6fdcbf7ac832c53c65d7
Cr-Commit-Position: refs/heads/master@{#34579}