Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: tests/git_footers_test.py

Issue 1761743002: git cl upload for Gerit no-squash: correct detect missing Change-Id. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@G0800
Patch Set: fix tests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/git_cl_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_footers_test.py
diff --git a/tests/git_footers_test.py b/tests/git_footers_test.py
index bb6e535506949edc841fd60940cbbd64d2cac4f9..86e8b6d93b08ea22c14a934c954327e3531ea647 100755
--- a/tests/git_footers_test.py
+++ b/tests/git_footers_test.py
@@ -73,6 +73,10 @@ My commit message is my best friend. It is my life. I must master it.
'', # Above is ignored because of this empty line.
'Change-Id: Ideadbeaf'])
self.assertEqual(['Ideadbeaf'], git_footers.get_footer_change_id(msg))
+ self.assertEqual([], git_footers.get_footer_change_id(
+ 'desc\nBUG=not-a-valid-footer\nChange-Id: Ixxx'))
+ self.assertEqual(['Ixxx'], git_footers.get_footer_change_id(
+ 'desc\nBUG=not-a-valid-footer\n\nChange-Id: Ixxx'))
def testAddFooterChangeId(self):
self.assertEqual(
« no previous file with comments | « tests/git_cl_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698