third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js - Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prepare-bindings-module

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('j') | third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

index 8f53f3ae4adb1669bb2565447044f923bb8ca6af..10c0ff157c8888ad79f29f35246b3333f5c6187c 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js

@@ -401,11 +401,12 @@ WebInspector.DeviceModeToolbar.prototype = {

_deviceListChanged: function()

{

- if (!this._model.device())

+ var model = this._model.device();

lushnikov 2016/03/04 05:06:58 model => device

kozy 2016/03/04 06:13:29 Done.

+ if (!model)

return;

var devices = this._allDevices();

- if (devices.indexOf(this._model.device()) === -1) {

+ if (devices.indexOf(model) === -1) {

if (devices.length)

this._emulateDevice(devices[0]);

else