third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js - Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prepare-bindings-module

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js ('K') | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

index 2df06bff5283ad51472368cb1ebe9ac500497b06..500fc75ebf9d6158b3d71390c209b544efc93499 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

@@ -152,8 +152,8 @@ WebInspector.DevicesSettingsTab.prototype = {

device.deviceScaleFactor = editor.control("scale").value ? parseFloat(editor.control("scale").value) : 0;

device.userAgent = editor.control("user-agent").value;

device.modes = [];

- device.modes.push({title: "", orientation: WebInspector.EmulatedDevice.Vertical, insets: new Insets(0, 0, 0, 0), images: null});

- device.modes.push({title: "", orientation: WebInspector.EmulatedDevice.Horizontal, insets: new Insets(0, 0, 0, 0), images: null});

+ device.modes.push({title: "", orientation: WebInspector.EmulatedDevice.Vertical, insets: new Insets(0, 0, 0, 0), image: null});

lushnikov 2016/03/04 05:06:58 nice!

+ device.modes.push({title: "", orientation: WebInspector.EmulatedDevice.Horizontal, insets: new Insets(0, 0, 0, 0), image: null});

device.capabilities = [];

var uaType = editor.control("ua-type").value;

if (uaType === WebInspector.DeviceModeModel.UA.Mobile || uaType === WebInspector.DeviceModeModel.UA.MobileNoTouch)