third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js - Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js

Issue 1761243002: [DevTools] Fix compile errors before closure compiler roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prepare-bindings-module

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/audits/AuditRules.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js b/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js

index e40ccf40ca2caa2770506e41ab652b34163f0ec1..2cb4021fff243675b4c143966e3c9567078adafd 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js

@@ -233,7 +233,7 @@ WebInspector.TempFile.prototype = {

WebInspector.DeferredTempFile = function(dirPath, name)

{

- /** @type {!Array.<!{strings: !Array.<string>, callback: function(number)}>} */

+ /** @type {!Array.<!{strings: !Array.<string>, callback: (function(number)|undefined)}>} */

lushnikov 2016/03/04 05:06:58 null

kozy 2016/03/04 06:13:29 Done.

this._chunks = [];

this._tempFile = null;

this._isWriting = false;

@@ -301,7 +301,7 @@ WebInspector.DeferredTempFile.prototype = {

return;

var chunk = this._chunks.shift();

this._isWriting = true;

- this._tempFile.write(/** @type {!Array.<string>} */(chunk.strings), this._didWriteChunk.bind(this, chunk.callback));

+ this._tempFile.write(/** @type {!Array.<string>} */(chunk.strings), this._didWriteChunk.bind(this, chunk.callback || null));

/**