Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1755423002: Add a test for application lifecycle (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@27amtest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for application lifecycle Adds an optional process-group field to the manifest which allows apps packaged together to be run in specific processes scoped by the package name. (basically: a way to set the qualifier field). R=sky@chromium.org BUG= Committed: https://crrev.com/0c9f518f04f10e9282bc6ba0b9008a7624570142 Cr-Commit-Position: refs/heads/master@{#379154}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+904 lines, -33 lines) Patch
M mojo/services/package_manager/package_manager.h View 1 2 3 4 5 6 7 8 9 5 chunks +9 lines, -6 lines 0 comments Download
M mojo/services/package_manager/package_manager.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +30 lines, -21 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/application_runner.h View 1 2 3 10 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M mojo/shell/tests/BUILD.gn View 1 10 1 chunk +1 line, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +110 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/app.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/app_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/app_client.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/app_manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/lifecycle_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +388 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/lifecycle_unittest.mojom View 1 chunk +23 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/lifecycle_unittest_manifest.json View 1 chunk +5 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/package.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +152 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/package_app_a_manifest.json View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/package_app_b_manifest.json View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
A mojo/shell/tests/lifecycle/package_manifest.json View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Ben Goodger (Google)
4 years, 9 months ago (2016-03-03 21:22:27 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-03 21:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755423002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755423002/240001
4 years, 9 months ago (2016-03-03 22:01:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/191210)
4 years, 9 months ago (2016-03-03 22:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755423002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755423002/260001
4 years, 9 months ago (2016-03-03 22:32:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/139524)
4 years, 9 months ago (2016-03-03 23:00:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755423002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755423002/280001
4 years, 9 months ago (2016-03-03 23:16:48 UTC) #16
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 9 months ago (2016-03-04 00:35:58 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 00:38:20 UTC) #20
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/0c9f518f04f10e9282bc6ba0b9008a7624570142
Cr-Commit-Position: refs/heads/master@{#379154}

Powered by Google App Engine
This is Rietveld 408576698