Pull and build shaderc rather than use checked in lib/header

Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003

Committed: https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2

Committed: https://skia.googlesource.com/skia/+/de7bbab69946aaac267197a87255f53d28e0b5da

[bsalomon, 2016-03-02 19:22:40]

Description was changed from

==========
Shaderc
==========

to

==========
Shaderc
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-02 22:26:27]

Description was changed from

==========
Shaderc
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-03-02 22:26:27]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[bsalomon, 2016-03-02 22:26:51]

This will require that you have cmake installed and in your path.

[egdaniel, 2016-03-02 22:52:43]

This lgtm. Just a heads up though, looks like they've made a change to fix the
ToT build sitting in the pull requests
(https://github.com/google/shaderc/pulls).

Also, looks like a change for a "simple building" script which might be of
interest.

[bsalomon, 2016-03-02 23:04:36]

On 2016/03/02 22:52:43, egdaniel wrote:
> This lgtm. Just a heads up though, looks like they've made a change to fix the
> ToT build sitting in the pull requests
> (https://github.com/google/shaderc/pulls).
> 
> Also, looks like a change for a "simple building" script which might be of
> interest.

Great, will land this and look at replacing my script with theirs before
attempting linux.

[bsalomon, 2016-03-02 23:04:39]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-03-02 23:04:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/100001

[commit-bot: I haz the power, 2016-03-02 23:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 23:07:20]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bsalomon, 2016-03-02 23:27:42]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-02 23:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1760493003/#ps120001
(title: "fix line length")

[commit-bot: I haz the power, 2016-03-02 23:27:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/120001

[commit-bot: I haz the power, 2016-03-02 23:59:27]

Description was changed from

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2
==========

[commit-bot: I haz the power, 2016-03-02 23:59:28]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2

[borenet, 2016-03-03 12:58:51]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1758743003/ by borenet@google.com.

The reason for reverting is: `gclient sync` fails on bots after this change due
to broken line endings in
https://github.com/google/glslang/blob/master/Test/100.conf.

[bsalomon, 2016-03-03 17:57:10]

Description was changed from

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2
==========

to

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2
==========

[bsalomon, 2016-03-03 17:57:17]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 17:57:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/140001

[commit-bot: I haz the power, 2016-03-03 17:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 17:59:20]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2016-03-03 19:18:53]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-03 19:18:54]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1760493003/#ps140001
(title: "Pull from fork of glsang with line ending fixes")

[commit-bot: I haz the power, 2016-03-03 19:18:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/140001

[commit-bot: I haz the power, 2016-03-03 19:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 19:21:56]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-03-03 23:17:30]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-03-03 23:17:31]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1760493003/#ps160001
(title: "use shaderc2 dir
")

[bsalomon, 2016-03-03 23:17:33]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-03-03 23:17:42]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 23:17:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/160001

[commit-bot: I haz the power, 2016-03-03 23:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:35:04]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-03-03 23:41:40]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-03-03 23:41:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760493003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760493003/160001

[commit-bot: I haz the power, 2016-03-03 23:43:07]

Description was changed from

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2
==========

to

==========
Pull and build shaderc rather than use checked in lib/header

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2

Committed:
https://skia.googlesource.com/skia/+/de7bbab69946aaac267197a87255f53d28e0b5da
==========

[commit-bot: I haz the power, 2016-03-03 23:43:08]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/de7bbab69946aaac267197a87255f53d28e0b5da