Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1760253003: [crankshaft] Support ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@tco-crank-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Support ES6 tail call elimination. HInvokeFunction and HApplyArguments instructions now support tail calling. Inlining of calls at tail position is not supported yet and therefore still disabled. The tail-call-megatest was modified so that the usages of "arguments" object do not disable Crankshaft. TBR=bmeurer@chromium.org BUG=v8:4698 LOG=N Committed: https://crrev.com/22938040fdb9a061babe96f004355fd79b2958a0 Cr-Commit-Position: refs/heads/master@{#34542}

Patch Set 1 : #

Patch Set 2 : Fix for a handle dereference issue. #

Patch Set 3 : ia32, arm and arm64 ports and x64 refactoring #

Patch Set 4 : mips and mips64 ports #

Patch Set 5 : Comments and test updated #

Total comments: 4

Patch Set 6 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1346 lines, -536 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 3 chunks +9 lines, -46 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 3 chunks +8 lines, -47 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 3 4 4 chunks +99 lines, -18 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 3 4 4 chunks +99 lines, -17 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 6 chunks +8 lines, -19 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 4 chunks +41 lines, -34 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 3 4 4 chunks +101 lines, -20 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 3 4 4 chunks +99 lines, -18 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 3 4 4 chunks +96 lines, -18 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 3 4 4 chunks +98 lines, -22 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 4 2 chunks +10 lines, -50 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 3 chunks +12 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 2 chunks +9 lines, -46 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 2 chunks +8 lines, -45 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 4 2 chunks +9 lines, -48 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 3 chunks +12 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call.js View 9 chunks +10 lines, -0 lines 0 comments Download
M test/mjsunit/es6/tail-call-megatest.js View 1 2 3 4 5 15 chunks +129 lines, -61 lines 0 comments Download
M test/mjsunit/es6/tail-call-simple.js View 5 chunks +40 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 37 (25 generated)
Igor Sheludko
PTAL x64 part. Ports are on the way.
4 years, 9 months ago (2016-03-04 09:56:31 UTC) #6
Igor Sheludko
Michi, PTAL x64 part. Ports are on the way.
4 years, 9 months ago (2016-03-04 10:02:26 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760253003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760253003/140001
4 years, 9 months ago (2016-03-05 00:29:22 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-05 00:49:53 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760253003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760253003/160001
4 years, 9 months ago (2016-03-07 09:05:50 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760253003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760253003/240001
4 years, 9 months ago (2016-03-07 11:29:40 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 11:51:47 UTC) #27
Michael Starzinger
LGTM. https://codereview.chromium.org/1760253003/diff/240001/test/mjsunit/es6/tail-call-megatest.js File test/mjsunit/es6/tail-call-megatest.js (right): https://codereview.chromium.org/1760253003/diff/240001/test/mjsunit/es6/tail-call-megatest.js#newcode48 test/mjsunit/es6/tail-call-megatest.js:48: // Check arguements manually to avoid bailing out ...
4 years, 9 months ago (2016-03-07 13:51:45 UTC) #28
Igor Sheludko
Landing... https://codereview.chromium.org/1760253003/diff/240001/test/mjsunit/es6/tail-call-megatest.js File test/mjsunit/es6/tail-call-megatest.js (right): https://codereview.chromium.org/1760253003/diff/240001/test/mjsunit/es6/tail-call-megatest.js#newcode48 test/mjsunit/es6/tail-call-megatest.js:48: // Check arguements manually to avoid bailing out ...
4 years, 9 months ago (2016-03-07 13:57:51 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760253003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760253003/260001
4 years, 9 months ago (2016-03-07 13:58:08 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:260001)
4 years, 9 months ago (2016-03-07 14:34:07 UTC) #35
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 14:35:00 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/22938040fdb9a061babe96f004355fd79b2958a0
Cr-Commit-Position: refs/heads/master@{#34542}

Powered by Google App Engine
This is Rietveld 408576698