Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1761023003: [crankshaft] Correctly propagate TailCallMode in case of inlining. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Correctly propagate TailCallMode in case of inlining. This CL also disables inlining of calls at tail position. This is a preparational step. Tail call elimination itself is neither enabled nor supported yet. BUG=v8:4698 LOG=N Committed: https://crrev.com/98c34e600dd0cff31caf314b9c7539200ff781f4 Cr-Commit-Position: refs/heads/master@{#34484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -67 lines) Patch
M src/crankshaft/hydrogen.h View 6 chunks +24 lines, -11 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 33 chunks +92 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761023003/1
4 years, 9 months ago (2016-03-04 08:43:56 UTC) #3
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-04 08:55:00 UTC) #5
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-04 08:56:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-04 09:08:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1761023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1761023003/1
4 years, 9 months ago (2016-03-04 09:15:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-04 09:17:33 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 09:18:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98c34e600dd0cff31caf314b9c7539200ff781f4
Cr-Commit-Position: refs/heads/master@{#34484}

Powered by Google App Engine
This is Rietveld 408576698