Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 1760153002: Check slot's distribution state more strictly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h
index d66676a8d6154332d6671b602ce07b423e744ea2..828099919c1145bf7ecd888e6d359ed7fa495e6e 100644
--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h
@@ -56,7 +56,7 @@ public:
void appendAssignedNode(Node&);
void appendDistributedNode(Node&);
void appendDistributedNodesFrom(const HTMLSlotElement& other);
- void clearDistribution();
+ void willUpdateDistribution();
kochi 2016/03/04 03:49:07 nit: Looking at usages, I'd think renaming willUpd
bool hasSlotChangeEventListener();
@@ -74,11 +74,13 @@ private:
HTMLSlotElement(Document&);
enum DistributionState {
- DistributionReset,
+ DistributionOnGoing,
+ DistributionDone,
DistributionChanged,
DistributionUnchanged
};
+ void clearDistribution();
void childrenChanged(const ChildrenChange&) final;
InsertionNotificationRequest insertedInto(ContainerNode*) final;
void removedFrom(ContainerNode*) final;

Powered by Google App Engine
This is Rietveld 408576698