third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp - Issue 1760153002: Check slot's distribution state more strictly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Issue 1760153002: Check slot's distribution state more strictly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

index 3e43b8906d23964d9cdad9f145e7bdffaaf6aec2..9fd8dd3547629d16026d7a16b70710cd88417ba1 100644

--- a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

@@ -36,7 +36,7 @@ void SlotAssignment::resolveAssignment(ShadowRoot& shadowRoot)

const WillBeHeapVector<RefPtrWillBeMember<HTMLSlotElement>>& slots = shadowRoot.descendantSlots();

for (RefPtrWillBeMember<HTMLSlotElement> slot : slots) {

- slot->clearDistribution();

+ slot->willUpdateDistribution();

AtomicString name = slot->fastGetAttribute(HTMLNames::nameAttr);

if (name.isNull() || name.isEmpty()) {

if (!defaultSlot)