Add support for new bitmapshader context (patchset #5 id:80001 of https://codereview.chromium.org/1…

Add support for new bitmapshader context (patchset #5 id:80001 of https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760123003

Committed: https://skia.googlesource.com/skia/+/d8829015768a1cf989ffb13e6e632c8f21d339db

[reed1, 2016-03-03 18:21:49]

Description was changed from

==========
Add support for new bitmapshader context (patchset #5 id:80001 of
https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
==========

to

==========
Add support for new bitmapshader context (patchset #5 id:80001 of
https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-03-04 16:21:15]

reed@google.com changed reviewers:
+ fmalita@chromium.org, herb@google.com, mtklein@google.com

[reed1, 2016-03-04 16:21:16]

*should* be correct with its new alignment scheme

[reed1, 2016-03-04 16:22:06]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-04 16:22:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760123003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760123003/60001

[commit-bot: I haz the power, 2016-03-04 16:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 16:34:55]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-03-04 16:39:46]

lgtm

[f(malita), 2016-03-04 16:52:29]

lgtm

https://codereview.chromium.org/1760123003/diff/60001/src/core/SkBitmapProcSh...
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/1760123003/diff/60001/src/core/SkBitmapProcSh...
src/core/SkBitmapProcShader.cpp:133: sk_sp<SkXfermode>
xfer(SkXfermode::Create(SkXfermode::kSrc_Mode));
w00t!

https://codereview.chromium.org/1760123003/diff/60001/src/core/SkBitmapProcSh...
src/core/SkBitmapProcShader.cpp:216: if (SkShader::kMirror_TileMode == tmx ||
SkShader::kMirror_TileMode == tmy) {
Is this a temporary limitation?

[reed1, 2016-03-04 18:49:42]

https://codereview.chromium.org/1760123003/diff/60001/src/core/SkBitmapProcSh...
File src/core/SkBitmapProcShader.cpp (right):

https://codereview.chromium.org/1760123003/diff/60001/src/core/SkBitmapProcSh...
src/core/SkBitmapProcShader.cpp:216: if (SkShader::kMirror_TileMode == tmx ||
SkShader::kMirror_TileMode == tmy) {
On 2016/03/04 16:52:29, f(malita) wrote:
> Is this a temporary limitation?

Yes. Documented as such.

[reed1, 2016-03-04 18:49:50]

The CQ bit was checked by reed@google.com

[reed1, 2016-03-04 18:49:50]

The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com,
fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1760123003/#ps80001
(title: "add dox")

[commit-bot: I haz the power, 2016-03-04 18:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1760123003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1760123003/80001

[commit-bot: I haz the power, 2016-03-04 19:07:46]

Description was changed from

==========
Add support for new bitmapshader context (patchset #5 id:80001 of
https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add support for new bitmapshader context (patchset #5 id:80001 of
https://codereview.chromium.org/1757993002/ )"

This reverts commit cd660e1c07371d9cf97824245639b1c0b5ac92fc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d8829015768a1cf989ffb13e6e632c8f21d339db
==========

[commit-bot: I haz the power, 2016-03-04 19:07:47]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d8829015768a1cf989ffb13e6e632c8f21d339db