Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1760103003: Switch to linear filtering for video frames on Android. (Closed)

Created:
4 years, 9 months ago by liberato (no reviews please)
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to linear filtering for video frames on Android. Power measurements on N5 showed no change for 480p30 and 1080p60, when scaling display size either to 480 or to 1080, when compared to nearest neighbor. BUG=591510 Committed: https://crrev.com/7c358317e9d2dd7827cd597ff81893b0549eba0f Cr-Commit-Position: refs/heads/master@{#379078}

Patch Set 1 #

Patch Set 2 : don't use nearest for copying strategy #

Patch Set 3 : comments. #

Patch Set 4 : also don't use it for CopySurfaceTextureToPictures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/common/gpu/media/android_copying_backing_strategy.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_deferred_rendering_backing_strategy.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/common/gpu/media/avda_codec_image.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
liberato (no reviews please)
any power change was well below the noise. thanks -fl
4 years, 9 months ago (2016-03-03 18:50:10 UTC) #3
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-03 19:18:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1760103003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1760103003/60001
4 years, 9 months ago (2016-03-03 19:21:30 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-03 20:44:27 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 20:46:38 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7c358317e9d2dd7827cd597ff81893b0549eba0f
Cr-Commit-Position: refs/heads/master@{#379078}

Powered by Google App Engine
This is Rietveld 408576698