Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 17601010: [CSS Grid Layout] Rename grid placement properties (Closed)

Created:
7 years, 6 months ago by svillar
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Rename grid placement properties The 8 May's specification changed the names of the grid positions to grid-column-{start|end} and grid-row-{start|end}. BUG=240317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153235

Patch Set 1 #

Total comments: 8

Patch Set 2 : Sorted properties and extra changes to the test utils #

Patch Set 3 : rebased #

Patch Set 4 : missing webposed/ changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+818 lines, -817 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html View 2 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt View 1 chunk +60 lines, -60 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html View 3 chunks +14 lines, -14 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt View 1 chunk +280 lines, -280 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html View 1 3 chunks +43 lines, -43 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt View 1 chunk +100 lines, -100 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html View 1 3 chunks +46 lines, -46 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt View 1 chunk +98 lines, -98 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js View 1 6 chunks +57 lines, -57 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/css/StylePropertyShorthand.cpp View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/rendering/style/StyleGridItemData.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/style/StyleGridItemData.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Julien - ping for review
lgtm (awesome with mostly nits!) I would check with Tab that those properties won't change ...
7 years, 6 months ago (2013-06-25 17:14:37 UTC) #1
svillar
Added a new CL with the suggested changes https://codereview.chromium.org/17601010/diff/1/Source/core/css/CSSPropertyNames.in File Source/core/css/CSSPropertyNames.in (right): https://codereview.chromium.org/17601010/diff/1/Source/core/css/CSSPropertyNames.in#newcode291 Source/core/css/CSSPropertyNames.in:291: grid-area ...
7 years, 5 months ago (2013-06-26 16:04:02 UTC) #2
TabAtkins
On 2013/06/25 17:14:37, Julien Chaffraix wrote: > I would check with Tab that those properties ...
7 years, 5 months ago (2013-06-26 16:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/17601010/14001
7 years, 5 months ago (2013-06-28 11:14:00 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-06-28 12:23:27 UTC) #5
Message was sent while issue was closed. 
Change committed as 153235

Powered by Google App Engine
This is Rietveld 408576698