Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 17601010: [CSS Grid Layout] Rename grid placement properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: missing webposed/ changes Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/StylePropertyShorthand.cpp ('k') | Source/core/page/RuntimeCSSEnabled.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 1648 matching lines...) Expand 10 before | Expand all | Expand 10 after
1659 // RenderSVGRoot handles zooming for the whole SVG subtree, so foreignOb ject content should 1659 // RenderSVGRoot handles zooming for the whole SVG subtree, so foreignOb ject content should
1660 // not be scaled again. 1660 // not be scaled again.
1661 if (e->hasTagName(SVGNames::foreignObjectTag)) 1661 if (e->hasTagName(SVGNames::foreignObjectTag))
1662 style->setEffectiveZoom(RenderStyle::initialZoom()); 1662 style->setEffectiveZoom(RenderStyle::initialZoom());
1663 } 1663 }
1664 } 1664 }
1665 1665
1666 void StyleResolver::adjustGridItemPosition(RenderStyle* style) const 1666 void StyleResolver::adjustGridItemPosition(RenderStyle* style) const
1667 { 1667 {
1668 // If opposing grid-placement properties both specify a grid span, they both compute to ‘auto’. 1668 // If opposing grid-placement properties both specify a grid span, they both compute to ‘auto’.
1669 if (style->gridStart().isSpan() && style->gridEnd().isSpan()) { 1669 if (style->gridColumnStart().isSpan() && style->gridColumnEnd().isSpan()) {
1670 style->setGridStart(GridPosition()); 1670 style->setGridColumnStart(GridPosition());
1671 style->setGridEnd(GridPosition()); 1671 style->setGridColumnEnd(GridPosition());
1672 } 1672 }
1673 1673
1674 if (style->gridBefore().isSpan() && style->gridAfter().isSpan()) { 1674 if (style->gridRowStart().isSpan() && style->gridRowEnd().isSpan()) {
1675 style->setGridBefore(GridPosition()); 1675 style->setGridRowStart(GridPosition());
1676 style->setGridAfter(GridPosition()); 1676 style->setGridRowEnd(GridPosition());
1677 } 1677 }
1678 } 1678 }
1679 1679
1680 bool StyleResolver::checkRegionStyle(Element* regionElement) 1680 bool StyleResolver::checkRegionStyle(Element* regionElement)
1681 { 1681 {
1682 // FIXME (BUG 72472): We don't add @-webkit-region rules of scoped style she ets for the moment, 1682 // FIXME (BUG 72472): We don't add @-webkit-region rules of scoped style she ets for the moment,
1683 // so all region rules are global by default. Verify whether that can stand or needs changing. 1683 // so all region rules are global by default. Verify whether that can stand or needs changing.
1684 1684
1685 if (ScopedStyleResolver* scopedResolver = m_styleTree.scopedStyleResolverFor Document()) 1685 if (ScopedStyleResolver* scopedResolver = m_styleTree.scopedStyleResolverFor Document())
1686 if (scopedResolver->checkRegionStyle(regionElement)) 1686 if (scopedResolver->checkRegionStyle(regionElement))
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
2971 2971
2972 Vector<GridTrackSize> trackSizes; 2972 Vector<GridTrackSize> trackSizes;
2973 NamedGridLinesMap namedGridLines; 2973 NamedGridLinesMap namedGridLines;
2974 if (!createGridTrackList(value, trackSizes, namedGridLines, state)) 2974 if (!createGridTrackList(value, trackSizes, namedGridLines, state))
2975 return; 2975 return;
2976 state.style()->setGridDefinitionRows(trackSizes); 2976 state.style()->setGridDefinitionRows(trackSizes);
2977 state.style()->setNamedGridRowLines(namedGridLines); 2977 state.style()->setNamedGridRowLines(namedGridLines);
2978 return; 2978 return;
2979 } 2979 }
2980 2980
2981 case CSSPropertyGridStart: { 2981 case CSSPropertyGridColumnStart: {
2982 HANDLE_INHERIT_AND_INITIAL(gridStart, GridStart); 2982 HANDLE_INHERIT_AND_INITIAL(gridColumnStart, GridColumnStart);
2983 GridPosition startPosition; 2983 GridPosition startPosition;
2984 if (!createGridPosition(value, startPosition)) 2984 if (!createGridPosition(value, startPosition))
2985 return; 2985 return;
2986 state.style()->setGridStart(startPosition); 2986 state.style()->setGridColumnStart(startPosition);
2987 return; 2987 return;
2988 } 2988 }
2989 case CSSPropertyGridEnd: { 2989 case CSSPropertyGridColumnEnd: {
2990 HANDLE_INHERIT_AND_INITIAL(gridEnd, GridEnd); 2990 HANDLE_INHERIT_AND_INITIAL(gridColumnEnd, GridColumnEnd);
2991 GridPosition endPosition; 2991 GridPosition endPosition;
2992 if (!createGridPosition(value, endPosition)) 2992 if (!createGridPosition(value, endPosition))
2993 return; 2993 return;
2994 state.style()->setGridEnd(endPosition); 2994 state.style()->setGridColumnEnd(endPosition);
2995 return; 2995 return;
2996 } 2996 }
2997 2997
2998 case CSSPropertyGridBefore: { 2998 case CSSPropertyGridRowStart: {
2999 HANDLE_INHERIT_AND_INITIAL(gridBefore, GridBefore); 2999 HANDLE_INHERIT_AND_INITIAL(gridRowStart, GridRowStart);
3000 GridPosition beforePosition; 3000 GridPosition beforePosition;
3001 if (!createGridPosition(value, beforePosition)) 3001 if (!createGridPosition(value, beforePosition))
3002 return; 3002 return;
3003 state.style()->setGridBefore(beforePosition); 3003 state.style()->setGridRowStart(beforePosition);
3004 return; 3004 return;
3005 } 3005 }
3006 case CSSPropertyGridAfter: { 3006 case CSSPropertyGridRowEnd: {
3007 HANDLE_INHERIT_AND_INITIAL(gridAfter, GridAfter); 3007 HANDLE_INHERIT_AND_INITIAL(gridRowEnd, GridRowEnd);
3008 GridPosition afterPosition; 3008 GridPosition afterPosition;
3009 if (!createGridPosition(value, afterPosition)) 3009 if (!createGridPosition(value, afterPosition))
3010 return; 3010 return;
3011 state.style()->setGridAfter(afterPosition); 3011 state.style()->setGridRowEnd(afterPosition);
3012 return; 3012 return;
3013 } 3013 }
3014 3014
3015 // These properties are aliased and DeprecatedStyleBuilder already applied t he property on the prefixed version. 3015 // These properties are aliased and DeprecatedStyleBuilder already applied t he property on the prefixed version.
3016 case CSSPropertyTransitionDelay: 3016 case CSSPropertyTransitionDelay:
3017 case CSSPropertyTransitionDuration: 3017 case CSSPropertyTransitionDuration:
3018 case CSSPropertyTransitionProperty: 3018 case CSSPropertyTransitionProperty:
3019 case CSSPropertyTransitionTimingFunction: 3019 case CSSPropertyTransitionTimingFunction:
3020 return; 3020 return;
3021 // These properties are implemented in the DeprecatedStyleBuilder lookup tab le or in the new StyleBuilder. 3021 // These properties are implemented in the DeprecatedStyleBuilder lookup tab le or in the new StyleBuilder.
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
3690 info.addMember(m_state, "state"); 3690 info.addMember(m_state, "state");
3691 3691
3692 // FIXME: move this to a place where it would be called only once? 3692 // FIXME: move this to a place where it would be called only once?
3693 info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle"); 3693 info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle");
3694 info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyl e"); 3694 info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyl e");
3695 info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle" ); 3695 info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle" );
3696 info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSo urceStyle"); 3696 info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSo urceStyle");
3697 } 3697 }
3698 3698
3699 } // namespace WebCore 3699 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/StylePropertyShorthand.cpp ('k') | Source/core/page/RuntimeCSSEnabled.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698