Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 17601010: [CSS Grid Layout] Rename grid placement properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: missing webposed/ changes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/StylePropertyShorthand.cpp ('k') | Source/core/page/RuntimeCSSEnabled.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index 01daeb9f6769590ad0a17cdb7e5962f66a24cf63..bab69408d08f7429a52ab416323ae7f1b6b03e26 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -1666,14 +1666,14 @@ void StyleResolver::adjustRenderStyle(RenderStyle* style, RenderStyle* parentSty
void StyleResolver::adjustGridItemPosition(RenderStyle* style) const
{
// If opposing grid-placement properties both specify a grid span, they both compute to ‘auto’.
- if (style->gridStart().isSpan() && style->gridEnd().isSpan()) {
- style->setGridStart(GridPosition());
- style->setGridEnd(GridPosition());
+ if (style->gridColumnStart().isSpan() && style->gridColumnEnd().isSpan()) {
+ style->setGridColumnStart(GridPosition());
+ style->setGridColumnEnd(GridPosition());
}
- if (style->gridBefore().isSpan() && style->gridAfter().isSpan()) {
- style->setGridBefore(GridPosition());
- style->setGridAfter(GridPosition());
+ if (style->gridRowStart().isSpan() && style->gridRowEnd().isSpan()) {
+ style->setGridRowStart(GridPosition());
+ style->setGridRowEnd(GridPosition());
}
}
@@ -2978,37 +2978,37 @@ void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)
return;
}
- case CSSPropertyGridStart: {
- HANDLE_INHERIT_AND_INITIAL(gridStart, GridStart);
+ case CSSPropertyGridColumnStart: {
+ HANDLE_INHERIT_AND_INITIAL(gridColumnStart, GridColumnStart);
GridPosition startPosition;
if (!createGridPosition(value, startPosition))
return;
- state.style()->setGridStart(startPosition);
+ state.style()->setGridColumnStart(startPosition);
return;
}
- case CSSPropertyGridEnd: {
- HANDLE_INHERIT_AND_INITIAL(gridEnd, GridEnd);
+ case CSSPropertyGridColumnEnd: {
+ HANDLE_INHERIT_AND_INITIAL(gridColumnEnd, GridColumnEnd);
GridPosition endPosition;
if (!createGridPosition(value, endPosition))
return;
- state.style()->setGridEnd(endPosition);
+ state.style()->setGridColumnEnd(endPosition);
return;
}
- case CSSPropertyGridBefore: {
- HANDLE_INHERIT_AND_INITIAL(gridBefore, GridBefore);
+ case CSSPropertyGridRowStart: {
+ HANDLE_INHERIT_AND_INITIAL(gridRowStart, GridRowStart);
GridPosition beforePosition;
if (!createGridPosition(value, beforePosition))
return;
- state.style()->setGridBefore(beforePosition);
+ state.style()->setGridRowStart(beforePosition);
return;
}
- case CSSPropertyGridAfter: {
- HANDLE_INHERIT_AND_INITIAL(gridAfter, GridAfter);
+ case CSSPropertyGridRowEnd: {
+ HANDLE_INHERIT_AND_INITIAL(gridRowEnd, GridRowEnd);
GridPosition afterPosition;
if (!createGridPosition(value, afterPosition))
return;
- state.style()->setGridAfter(afterPosition);
+ state.style()->setGridRowEnd(afterPosition);
return;
}
« no previous file with comments | « Source/core/css/StylePropertyShorthand.cpp ('k') | Source/core/page/RuntimeCSSEnabled.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698