Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1760043002: Skip mirror tests more generally for $mode == product instead of $runtime == dart_product. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip mirror tests more generally for $mode == product instead of $runtime == dart_product. Reduces failures in tools/test.py -mproduct. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/167616b83e463a20acb711b68d375405b42a7a2c

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 2 chunks +14 lines, -10 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M tests/utils/utils.status View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years, 9 months ago (2016-03-03 00:06:24 UTC) #3
siva
lgtm https://codereview.chromium.org/1760043002/diff/20001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/1760043002/diff/20001/tests/co19/co19-runtime.status#newcode151 tests/co19/co19-runtime.status:151: Language/Expressions/Constants/static_method_t01: Crash # Issue 25892 The crashes need ...
4 years, 9 months ago (2016-03-03 17:31:16 UTC) #4
rmacnak
https://codereview.chromium.org/1760043002/diff/20001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/1760043002/diff/20001/tests/co19/co19-runtime.status#newcode151 tests/co19/co19-runtime.status:151: Language/Expressions/Constants/static_method_t01: Crash # Issue 25892 On 2016/03/03 17:31:16, siva ...
4 years, 9 months ago (2016-03-03 18:04:52 UTC) #5
rmacnak
4 years, 9 months ago (2016-03-03 18:07:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
167616b83e463a20acb711b68d375405b42a7a2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698