Skip mirror tests more generally for $mode == product instead of $runtime == dart_product.

tests/co19/co19-runtime.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 
 [ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) ]
 
 # Failures ok in tests below. VM moves super initializer to end of list.
 Language/Classes/Constructors/Generative_Constructors/execution_t03: Fail, OK
 Language/Expressions/Instance_Creation/New/execution_t04: Fail, OK
@@ skipping 124 matching lines @@
 Language/Mixins/reference_to_super_t01: MissingCompileTimeError # co19 issue 43 and 44
 
 [ ($runtime == vm || $runtime == dart_precompiled || $runtime == dart_product) && $checked ]
 Language/Errors_and_Warnings/static_warning_t01: RuntimeError # co19 issue 45
 Language/Errors_and_Warnings/static_warning_t02: RuntimeError # co19 issue 45
 Language/Errors_and_Warnings/static_warning_t03: RuntimeError # co19 issue 45
 Language/Errors_and_Warnings/static_warning_t04: RuntimeError # co19 issue 45
 Language/Errors_and_Warnings/static_warning_t05: RuntimeError # co19 issue 45
 Language/Errors_and_Warnings/static_warning_t06: RuntimeError # co19 issue 45
 
+[ $noopt || $compiler == precompiler || $mode == product ]
+Language/Metadata/*: SkipByDesign # Uses dart:mirrors
+
+[ $runtime == dart_precompiled || $runtime == dart_product ]
+LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
+Language/Expressions/Constants/identifier_denotes_a_constant_t05: Crash # Issue 25892
+Language/Expressions/Constants/static_method_t01: Crash # Issue 25892

[siva, 2016/03/03 17:31:16]

The crashes need to be dart_precompiled only.

[rmacnak, 2016/03/03 18:04:52]

Fixed.

+
 [ $noopt || $compiler == precompiler ]
-Language/Metadata/*: SkipByDesign # Uses dart:mirrors
 LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout
 LibTest/collection/ListMixin/ListMixin_class_A01_t02: Pass, Timeout
 LibTest/core/Map/Map_class_A01_t04: Pass, Timeout
 LibTest/core/Uri/encodeQueryComponent_A01_t02: Pass, Timeout
 
-[ $runtime == dart_precompiled ]
-LibTest/isolate/Isolate/spawnUri*: RuntimeError # Isolate.spawnUri
-Language/Expressions/Constants/identifier_denotes_a_constant_t05: Crash # Issue 25892
-Language/Expressions/Constants/static_method_t01: Crash # Issue 25892
-
-[ $runtime == dart_product ]
-LibTest/isolate/Isolate/spawnUri*: Skip # Isolate.spawnUri
-Language/Metadata/*: SkipByDesign # Uses dart:mirrors
-
 [ $runtime == vm && $mode == product ]
 LibTest/typed_data/Float32List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Float32x4List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Float64List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Int16List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Int32List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Int64List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Int8List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Uint16List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Uint32List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Uint64List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Uint8ClampedList/runtimeType_A01_t01: Fail,OK  # Expects exact type name.
 LibTest/typed_data/Uint8List/runtimeType_A01_t01: Fail,OK  # Expects exact type name.