tests/lib/lib.status - Issue 1760043002: Skip mirror tests more generally for $mode == product instead of $runtime == dart_product.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/lib.status

Issue 1760043002: Skip mirror tests more generally for $mode == product instead of $runtime == dart_product. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/lib.status

diff --git a/tests/lib/lib.status b/tests/lib/lib.status

index 520ea2d455d77a3c893574e4a7871cb63664ef96..87b74f2bf002b6cd76982dee90d9d68456ac8466 100644

--- a/tests/lib/lib.status

+++ b/tests/lib/lib.status

@@ -354,11 +354,9 @@ async/dart2js_uncaught_error_test: Skip # JS-integration only test

[ $noopt && $arch == simarm64 ]

async/slow_consumer2_test: Pass, RuntimeError # Issue 25726

-[ $noopt || $compiler == precompiler ]

+[ $noopt || $compiler == precompiler || $mode == product ]

mirrors/*: SkipByDesign

+[ $noopt || $compiler == precompiler ]

convert/chunked_conversion_utf88_test: Pass, Timeout

convert/utf85_test: Pass, Timeout

-[ $runtime == vm && $mode == product ]

-mirrors/mirrors_reader_test: Fail,OK # Expects exact type name.

« no previous file with comments | « tests/language/language.status ('k') | tests/utils/utils.status » ('j') | no next file with comments »