src/heap.cc - Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 06c54a9bc00dde300d3f53c1b9752264a7ac507a..005a5f8d5f75036bc06a824e2a5ac6985fca01e4 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -3155,7 +3155,7 @@ bool Heap::CreateInitialObjects() {

set_empty_slow_element_dictionary(SeededNumberDictionary::cast(obj));

// Handling of script id generation is in Factory::NewScript.

- set_last_script_id(undefined_value());

+ set_last_script_id(Smi::FromInt(v8::Script::kNoScriptId));

// Initialize keyed lookup cache.

isolate_->keyed_lookup_cache()->Clear();

« no previous file with comments | « src/heap.h ('k') | src/heap-inl.h » ('j') | no next file with comments »