src/heap-inl.h - Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-inl.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: comments addressed Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-inl.h

diff --git a/src/heap-inl.h b/src/heap-inl.h

index 2d0968d34195d7ab6a2f1c87f2518323facf55b4..92ae8e54b568284b83ecf46328fcf88fc451b276 100644

--- a/src/heap-inl.h

+++ b/src/heap-inl.h

@@ -570,11 +570,6 @@ intptr_t Heap::AdjustAmountOfExternalAllocatedMemory(

}

-void Heap::SetLastScriptId(Object* last_script_id) {

- roots_[kLastScriptIdRootIndex] = last_script_id;

Isolate* Heap::isolate() {

return reinterpret_cast<Isolate*>(reinterpret_cast<intptr_t>(this) -

reinterpret_cast<size_t>(reinterpret_cast<Isolate*>(4)->heap()) + 4);

« no previous file with comments | « src/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »