Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/heap.cc

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.h ('k') | src/heap-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3137 matching lines...) Expand 10 before | Expand all | Expand 10 after
3148 } 3148 }
3149 set_frozen_symbol(Symbol::cast(obj)); 3149 set_frozen_symbol(Symbol::cast(obj));
3150 3150
3151 { MaybeObject* maybe_obj = SeededNumberDictionary::Allocate(this, 0, TENURED); 3151 { MaybeObject* maybe_obj = SeededNumberDictionary::Allocate(this, 0, TENURED);
3152 if (!maybe_obj->ToObject(&obj)) return false; 3152 if (!maybe_obj->ToObject(&obj)) return false;
3153 } 3153 }
3154 SeededNumberDictionary::cast(obj)->set_requires_slow_elements(); 3154 SeededNumberDictionary::cast(obj)->set_requires_slow_elements();
3155 set_empty_slow_element_dictionary(SeededNumberDictionary::cast(obj)); 3155 set_empty_slow_element_dictionary(SeededNumberDictionary::cast(obj));
3156 3156
3157 // Handling of script id generation is in Factory::NewScript. 3157 // Handling of script id generation is in Factory::NewScript.
3158 set_last_script_id(undefined_value()); 3158 set_last_script_id(Smi::FromInt(v8::Script::kNoScriptId));
3159 3159
3160 // Initialize keyed lookup cache. 3160 // Initialize keyed lookup cache.
3161 isolate_->keyed_lookup_cache()->Clear(); 3161 isolate_->keyed_lookup_cache()->Clear();
3162 3162
3163 // Initialize context slot cache. 3163 // Initialize context slot cache.
3164 isolate_->context_slot_cache()->Clear(); 3164 isolate_->context_slot_cache()->Clear();
3165 3165
3166 // Initialize descriptor cache. 3166 // Initialize descriptor cache.
3167 isolate_->descriptor_lookup_cache()->Clear(); 3167 isolate_->descriptor_lookup_cache()->Clear();
3168 3168
(...skipping 4943 matching lines...) Expand 10 before | Expand all | Expand 10 after
8112 if (FLAG_parallel_recompilation) { 8112 if (FLAG_parallel_recompilation) {
8113 heap_->relocation_mutex_->Lock(); 8113 heap_->relocation_mutex_->Lock();
8114 #ifdef DEBUG 8114 #ifdef DEBUG
8115 heap_->relocation_mutex_locked_by_optimizer_thread_ = 8115 heap_->relocation_mutex_locked_by_optimizer_thread_ =
8116 heap_->isolate()->optimizing_compiler_thread()->IsOptimizerThread(); 8116 heap_->isolate()->optimizing_compiler_thread()->IsOptimizerThread();
8117 #endif // DEBUG 8117 #endif // DEBUG
8118 } 8118 }
8119 } 8119 }
8120 8120
8121 } } // namespace v8::internal 8121 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap.h ('k') | src/heap-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698