Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: src/heap-inl.h

Issue 17600006: CPUProfiler: It is not clear why we are using Handle<Object> for scriptId. Lets flip it into Smi/in… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap-inl.h
diff --git a/src/heap-inl.h b/src/heap-inl.h
index 2d0968d34195d7ab6a2f1c87f2518323facf55b4..b9dbf45cfdec1fe694a1859cfa5524d102d14ec2 100644
--- a/src/heap-inl.h
+++ b/src/heap-inl.h
@@ -570,8 +570,8 @@ intptr_t Heap::AdjustAmountOfExternalAllocatedMemory(
}
-void Heap::SetLastScriptId(Object* last_script_id) {
- roots_[kLastScriptIdRootIndex] = last_script_id;
+void Heap::SetLastScriptId(int last_script_id) {
+ roots_[kLastScriptIdRootIndex] = Smi::FromInt(last_script_id);
}

Powered by Google App Engine
This is Rietveld 408576698