Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1759603002: [debugger] Ensure at least one breakable position per function. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com, oth, rmcilroy, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Ensure at least one breakable position per function. The function literal consists of a list of statements. Each statement is associated with a statement position including break location. The only exception to this rule is when the function immediately throws if scope resolution found an illegal redeclaration. Make sure that we add a break location for this case as well. The debugger relies on this. R=bmeurer@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/44e9622aeaa5747dfc7c8c134f637ea47b267bb1 Cr-Commit-Position: refs/heads/master@{#34422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -29 lines) Patch
M src/debug/debug.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/interpreter/source-position-table.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 9 months ago (2016-03-02 08:37:19 UTC) #1
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-02 08:45:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759603002/1
4 years, 9 months ago (2016-03-02 09:02:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 10:30:38 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:32:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44e9622aeaa5747dfc7c8c134f637ea47b267bb1
Cr-Commit-Position: refs/heads/master@{#34422}

Powered by Google App Engine
This is Rietveld 408576698