Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1759603002: [debugger] Ensure at least one breakable position per function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 SetVar(arguments, v0, a1, a2); 299 SetVar(arguments, v0, a1, a2);
300 } 300 }
301 301
302 if (FLAG_trace) { 302 if (FLAG_trace) {
303 __ CallRuntime(Runtime::kTraceEnter); 303 __ CallRuntime(Runtime::kTraceEnter);
304 } 304 }
305 305
306 // Visit the declarations and body unless there is an illegal 306 // Visit the declarations and body unless there is an illegal
307 // redeclaration. 307 // redeclaration.
308 if (scope()->HasIllegalRedeclaration()) { 308 if (scope()->HasIllegalRedeclaration()) {
309 Comment cmnt(masm_, "[ Declarations"); 309 EmitIllegalRedeclaration();
310 VisitForEffect(scope()->GetIllegalRedeclaration());
311
312 } else { 310 } else {
313 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS); 311 PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);
314 { Comment cmnt(masm_, "[ Declarations"); 312 { Comment cmnt(masm_, "[ Declarations");
315 VisitDeclarations(scope()->declarations()); 313 VisitDeclarations(scope()->declarations());
316 } 314 }
317 315
318 // Assert that the declarations do not use ICs. Otherwise the debugger 316 // Assert that the declarations do not use ICs. Otherwise the debugger
319 // won't be able to redirect a PC at an IC to the correct IC in newly 317 // won't be able to redirect a PC at an IC to the correct IC in newly
320 // recompiled code. 318 // recompiled code.
321 DCHECK_EQ(0, ic_total_count_); 319 DCHECK_EQ(0, ic_total_count_);
(...skipping 3885 matching lines...) Expand 10 before | Expand all | Expand 10 after
4207 reinterpret_cast<uint32_t>( 4205 reinterpret_cast<uint32_t>(
4208 isolate->builtins()->OsrAfterStackCheck()->entry())); 4206 isolate->builtins()->OsrAfterStackCheck()->entry()));
4209 return OSR_AFTER_STACK_CHECK; 4207 return OSR_AFTER_STACK_CHECK;
4210 } 4208 }
4211 4209
4212 4210
4213 } // namespace internal 4211 } // namespace internal
4214 } // namespace v8 4212 } // namespace v8
4215 4213
4216 #endif // V8_TARGET_ARCH_MIPS 4214 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698