src/full-codegen/x64/full-codegen-x64.cc - Issue 1759603002: [debugger] Ensure at least one breakable position per function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1759603002: [debugger] Ensure at least one breakable position per function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index c920fab2c5cff6a3e359b113f17c5b44a6ee602b..483b21b0a92f5197b05528d3f5a109bfa889fe39 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -287,9 +287,7 @@ void FullCodeGenerator::Generate() {

// Visit the declarations and body unless there is an illegal

// redeclaration.

if (scope()->HasIllegalRedeclaration()) {

- Comment cmnt(masm_, "[ Declarations");

- VisitForEffect(scope()->GetIllegalRedeclaration());

+ EmitIllegalRedeclaration();

} else {

PrepareForBailoutForId(BailoutId::FunctionEntry(), NO_REGISTERS);

{ Comment cmnt(masm_, "[ Declarations");

« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »