Replace cloneNodeAndAssociate with Element::cloneElementWithChildren

Replace cloneNodeAndAssociate with Element::cloneElementWithChildren

Use the Element::cloneElementWithChildren to do a "straight" clone, and
then post-process it to associate the cloned nodes with their
corresponding elements.
Move the call to removeDisallowedElementsFromSubtree() into the cloning
sequence since it will have nothing to do if there's no target. The
root has already been verified to be "allowed", so the different
starting element makes no difference on the result.

BUG=589682
Committed: https://crrev.com/a47da5d1abada9975960e42de6d6f642d22a9322
Cr-Commit-Position: refs/heads/master@{#379046}

[fs, 2016-03-03 16:31:52]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-03-03 16:42:01]

LGTM. It reduces redundant code nicely.

https://codereview.chromium.org/1759553005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGUseElement.cpp (right):

https://codereview.chromium.org/1759553005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGUseElement.cpp:368:
ASSERT(!(targetIterator != targetRange.end()));
So we have a != operator but no == operator? Interesting.

[fs, 2016-03-03 16:59:08]

https://codereview.chromium.org/1759553005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGUseElement.cpp (right):

https://codereview.chromium.org/1759553005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGUseElement.cpp:368:
ASSERT(!(targetIterator != targetRange.end()));
On 2016/03/03 at 16:42:01, Stephen Chenney wrote:
> So we have a != operator but no == operator? Interesting.

Yeah, I guess it's heavily tailored to the range-based for usage.

[fs, 2016-03-03 17:56:19]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-03-03 17:56:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1759553005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1759553005/20001

[commit-bot: I haz the power, 2016-03-03 18:49:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 18:50:59]

Description was changed from

==========
Replace cloneNodeAndAssociate with Element::cloneElementWithChildren

Use the Element::cloneElementWithChildren to do a "straight" clone, and
then post-process it to associate the cloned nodes with their
corresponding elements.
Move the call to removeDisallowedElementsFromSubtree() into the cloning
sequence since it will have nothing to do if there's no target. The
root has already been verified to be "allowed", so the different
starting element makes no difference on the result.

BUG=589682
==========

to

==========
Replace cloneNodeAndAssociate with Element::cloneElementWithChildren

Use the Element::cloneElementWithChildren to do a "straight" clone, and
then post-process it to associate the cloned nodes with their
corresponding elements.
Move the call to removeDisallowedElementsFromSubtree() into the cloning
sequence since it will have nothing to do if there's no target. The
root has already been verified to be "allowed", so the different
starting element makes no difference on the result.

BUG=589682

Committed: https://crrev.com/a47da5d1abada9975960e42de6d6f642d22a9322
Cr-Commit-Position: refs/heads/master@{#379046}
==========

[commit-bot: I haz the power, 2016-03-03 18:51:00]

Patchset 2 (id:??) landed as
https://crrev.com/a47da5d1abada9975960e42de6d6f642d22a9322
Cr-Commit-Position: refs/heads/master@{#379046}