Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1762633002: Use references some more in SVGUseElement (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use references some more in SVGUseElement Mostly changes to pass SVGElement& rather than SVGElement* - and some cleanup/removal of dead null-checks etc. as a consequence. BUG=589682 Committed: https://crrev.com/ee36663a57409b66d72776c462f00427b128e3b4 Cr-Commit-Position: refs/heads/master@{#379031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 13 chunks +30 lines, -34 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fs
4 years, 9 months ago (2016-03-03 15:26:22 UTC) #7
Stephen Chennney
LGTM. Thanks for the ongoing work. Trybot failures are unrelated.
4 years, 9 months ago (2016-03-03 16:27:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1762633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1762633002/40001
4 years, 9 months ago (2016-03-03 16:31:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-03 17:38:02 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 17:39:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee36663a57409b66d72776c462f00427b128e3b4
Cr-Commit-Position: refs/heads/master@{#379031}

Powered by Google App Engine
This is Rietveld 408576698