Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1757323002: Eliminate SVGUseElement::referencedScope() (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-useelm-shadowbuilder-cleanup-7
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate SVGUseElement::referencedScope() During "shadow tree fixup" (SVGUseElement::expand*) we can use the document of the original (corresponding) element rather than referencedScope(), because the Document of those elements will be the external or the "local" respectively depending on source for the initial clone operation. This leaves a few users in buildPendingResource() which can be eliminated by folding the method into it. Hopefully this will also allow future cleanups to isExternalURIReference, since now it's not called unnecessarily for each nested <use>. (Possibly minor perf effect from eliminating the calls to referencedScope().) BUG=589682 Committed: https://crrev.com/c427062580ade2dde463ff0c51f33717099e6c9c Cr-Commit-Position: refs/heads/master@{#379074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M third_party/WebKit/Source/core/svg/SVGUseElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 5 chunks +16 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-03 17:57:02 UTC) #2
pdr.
On 2016/03/03 at 17:57:02, fs wrote: > LGTM
4 years, 9 months ago (2016-03-03 19:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757323002/1
4 years, 9 months ago (2016-03-03 20:28:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-03 20:35:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 20:37:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c427062580ade2dde463ff0c51f33717099e6c9c
Cr-Commit-Position: refs/heads/master@{#379074}

Powered by Google App Engine
This is Rietveld 408576698