Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515
Committed: https://crrev.com/d8f1339be5fc4859d1f211384fd9c053de3acb52
Cr-Commit-Position: refs/heads/master@{#379469}

[sof, 2016-03-04 12:59:58]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-03-04 12:59:58]

please take a look.

not sure how this one managed to stay around..

[haraken, 2016-03-04 15:55:58]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-03-04 15:55:59]

https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Visitor.h (left):

https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Visitor.h:388: bool
m_isGlobalMarkingVisitor;

Hmm, I remember kouhei@ introduced this flag for optimizing the marking phase.
Would you quickly blame a CL that removes the usage of m_isGlobalMarkingVisitor?

[sof, 2016-03-04 18:18:23]

https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Visitor.h (left):

https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Visitor.h:388: bool
m_isGlobalMarkingVisitor;
On 2016/03/04 15:55:59, haraken wrote:
> 
> Hmm, I remember kouhei@ introduced this flag for optimizing the marking phase.
> Would you quickly blame a CL that removes the usage of
m_isGlobalMarkingVisitor?

Yes, introduced in https://codereview.chromium.org/804303002 and no longer used
after https://codereview.chromium.org/1168683002

[haraken, 2016-03-05 03:23:28]

On 2016/03/04 18:18:23, sof wrote:
>
https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/heap/Visitor.h (left):
> 
>
https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/heap/Visitor.h:388: bool
> m_isGlobalMarkingVisitor;
> On 2016/03/04 15:55:59, haraken wrote:
> > 
> > Hmm, I remember kouhei@ introduced this flag for optimizing the marking
phase.
> > Would you quickly blame a CL that removes the usage of
> m_isGlobalMarkingVisitor?
> 
> Yes, introduced in https://codereview.chromium.org/804303002 and no longer
used
> after https://codereview.chromium.org/1168683002

Thanks, LGTM.

It looks okay to remove the branch in
https://codereview.chromium.org/1168683002/diff/1/Source/platform/heap/TraceT...,
because we hit the code only when we switch from the global marking visitor to
the inline marking visitor.

[sof, 2016-03-05 08:57:42]

On 2016/03/05 03:23:28, haraken wrote:
> On 2016/03/04 18:18:23, sof wrote:
> >
>
https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/platform/heap/Visitor.h (left):
> > 
> >
>
https://codereview.chromium.org/1759183005/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/platform/heap/Visitor.h:388: bool
> > m_isGlobalMarkingVisitor;
> > On 2016/03/04 15:55:59, haraken wrote:
> > > 
> > > Hmm, I remember kouhei@ introduced this flag for optimizing the marking
> phase.
> > > Would you quickly blame a CL that removes the usage of
> > m_isGlobalMarkingVisitor?
> > 
> > Yes, introduced in https://codereview.chromium.org/804303002 and no longer
> used
> > after https://codereview.chromium.org/1168683002
> 
> Thanks, LGTM.
> 
> It looks okay to remove the branch in
>
https://codereview.chromium.org/1168683002/diff/1/Source/platform/heap/TraceT...,
> because we hit the code only when we switch from the global marking visitor to
> the inline marking visitor.

Hmm, what makes you conclude so? It's needed for thread-local weak processing,
at least.

[sof, 2016-03-05 09:04:23]

Description was changed from

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=
BUG=420515
==========

to

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515
==========

[sof, 2016-03-05 09:04:46]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-05 09:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1759183005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1759183005/20001

[commit-bot: I haz the power, 2016-03-05 09:46:59]

Description was changed from

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515
==========

to

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515
==========

[commit-bot: I haz the power, 2016-03-05 09:47:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-05 09:48:11]

Description was changed from

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515
==========

to

==========
Remove now-unused Visitor::m_isGlobalMarkingVisitor field.

R=haraken
BUG=420515

Committed: https://crrev.com/d8f1339be5fc4859d1f211384fd9c053de3acb52
Cr-Commit-Position: refs/heads/master@{#379469}
==========

[commit-bot: I haz the power, 2016-03-05 09:48:12]

Patchset 2 (id:??) landed as
https://crrev.com/d8f1339be5fc4859d1f211384fd9c053de3acb52
Cr-Commit-Position: refs/heads/master@{#379469}