Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1168683002: Oilpan: Introduce WeakProcessingVisitor (Closed)

Created:
5 years, 6 months ago by haraken
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, keishi, sof
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Introduce WeakProcessingVisitor The main purpose of this CL is to remove a use of s_markingVisitor, since I'm going to remove the global variable in a follow-up CL (in preparation for implementing a visitor for a snapshot GC). This CL also add a bunch of ASSERTs to verify that a visitor for weak processing does not do things that the visitor is not allowed to do. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M Source/platform/heap/InlinedGlobalMarkingVisitor.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/heap/MarkingVisitorImpl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/platform/heap/TraceTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Visitor.h View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
5 years, 6 months ago (2015-06-05 04:19:49 UTC) #2
keishi
lgtm
5 years, 6 months ago (2015-06-05 05:57:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168683002/1
5 years, 6 months ago (2015-06-05 05:58:30 UTC) #5
sof
lgtm (i've kicked off some dbg bots to verify handling of ASSERT()s.)
5 years, 6 months ago (2015-06-05 06:00:04 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 06:01:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196557

Powered by Google App Engine
This is Rietveld 408576698