Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 1759183005: Remove now-unused Visitor::m_isGlobalMarkingVisitor field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: include tidying Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef Visitor_h 31 #ifndef Visitor_h
32 #define Visitor_h 32 #define Visitor_h
33 33
34 #include "platform/PlatformExport.h" 34 #include "platform/PlatformExport.h"
35 #include "platform/heap/GarbageCollected.h" 35 #include "platform/heap/GarbageCollected.h"
36 #include "platform/heap/StackFrameDepth.h"
37 #include "platform/heap/ThreadState.h"
38 #include "wtf/Allocator.h" 36 #include "wtf/Allocator.h"
39 #include "wtf/Assertions.h" 37 #include "wtf/Assertions.h"
40 #include "wtf/Atomics.h"
41 #include "wtf/Deque.h" 38 #include "wtf/Deque.h"
42 #include "wtf/Forward.h" 39 #include "wtf/Forward.h"
43 #include "wtf/HashMap.h"
44 #include "wtf/HashTraits.h" 40 #include "wtf/HashTraits.h"
45 #include "wtf/TypeTraits.h" 41 #include "wtf/TypeTraits.h"
46 42
47 namespace blink { 43 namespace blink {
48 44
49 template<typename T> class GarbageCollected; 45 template<typename T> class GarbageCollected;
50 class HeapObjectHeader; 46 class HeapObjectHeader;
51 class InlinedGlobalMarkingVisitor; 47 class InlinedGlobalMarkingVisitor;
52 template<typename T> class TraceTrait; 48 template<typename T> class TraceTrait;
53 template<typename T> class TraceEagerlyTrait; 49 template<typename T> class TraceEagerlyTrait;
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 protected: 374 protected:
379 Visitor(ThreadState*, MarkingMode); 375 Visitor(ThreadState*, MarkingMode);
380 376
381 virtual void registerWeakCellWithCallback(void**, WeakCallback) = 0; 377 virtual void registerWeakCellWithCallback(void**, WeakCallback) = 0;
382 378
383 private: 379 private:
384 static Visitor* fromHelper(VisitorHelper<Visitor>* helper) { return static_c ast<Visitor*>(helper); } 380 static Visitor* fromHelper(VisitorHelper<Visitor>* helper) { return static_c ast<Visitor*>(helper); }
385 381
386 ThreadState* m_state; 382 ThreadState* m_state;
387 const MarkingMode m_markingMode; 383 const MarkingMode m_markingMode;
388 bool m_isGlobalMarkingVisitor;
haraken 2016/03/04 15:55:59 Hmm, I remember kouhei@ introduced this flag for o
sof 2016/03/04 18:18:23 Yes, introduced in https://codereview.chromium.org
389 }; 384 };
390 385
391 } // namespace blink 386 } // namespace blink
392 387
393 #endif // Visitor_h 388 #endif // Visitor_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698