Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1759113002:
Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. (Closed)
|
Created:
4 years, 9 months ago by karandeepb Modified:
4 years, 9 months ago Reviewers:
Nico CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake shell_dialogs_unittests link correctly on Non-Windows gyp builds.
BUG=591663
Committed: https://crrev.com/711ed960a44b9efe6875c68a6d0b3795c5a742a0
Cr-Commit-Position: refs/heads/master@{#379503}
Patch Set 1 : #
Total comments: 3
Messages
Total messages: 14 (6 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Initial commit BUG= ========== to ========== Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG=591663 ==========
PTAL Nico. Thanks. https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... File ui/shell_dialogs/shell_dialogs.gyp (right): https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... ui/shell_dialogs/shell_dialogs.gyp:91: '../../base/test/run_all_unittests.cc', It seems that targets without any sources cause link errors with gyp. However, gn does not seem to have this problem. Any insights?
karandeepb@chromium.org changed reviewers: + thakis@chromium.org
PTAL Nico. Thanks.
https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... File ui/shell_dialogs/shell_dialogs.gyp (right): https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... ui/shell_dialogs/shell_dialogs.gyp:91: '../../base/test/run_all_unittests.cc', On 2016/03/04 04:08:27, karandeepb wrote: > It seems that targets without any sources cause link errors with gyp. However, > gn does not seem to have this problem. Any insights? It is true that a target without any sources can cause link errors with some of gyp's generators. However, this target already has a source file – why this change? What's the error message without this? …oh, I see the bug you linked to answers this. Can you paste the link line that's failing somewhere? It kind of looks like the executable is failing to link to libc++?
https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... File ui/shell_dialogs/shell_dialogs.gyp (right): https://codereview.chromium.org/1759113002/diff/20001/ui/shell_dialogs/shell_... ui/shell_dialogs/shell_dialogs.gyp:91: '../../base/test/run_all_unittests.cc', On 2016/03/04 07:33:21, Nico wrote: > On 2016/03/04 04:08:27, karandeepb wrote: > > It seems that targets without any sources cause link errors with gyp. However, > > gn does not seem to have this problem. Any insights? > > It is true that a target without any sources can cause link errors with some of > gyp's generators. However, this target already has a source file – why this > change? What's the error message without this? > > …oh, I see the bug you linked to answers this. Can you paste the link line > that's failing somewhere? It kind of looks like the executable is failing to > link to libc++? I have pasted the failing link line on the linked bug report. This target has a source file but it is only compiled and linked on Windows. This is the reason why build succeeds on Windows but not on other platforms.
ah, makes sense, lgtm
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1759113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1759113002/20001
Message was sent while issue was closed.
Description was changed from ========== Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG=591663 ========== to ========== Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG=591663 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG=591663 ========== to ========== Make shell_dialogs_unittests link correctly on Non-Windows gyp builds. BUG=591663 Committed: https://crrev.com/711ed960a44b9efe6875c68a6d0b3795c5a742a0 Cr-Commit-Position: refs/heads/master@{#379503} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/711ed960a44b9efe6875c68a6d0b3795c5a742a0 Cr-Commit-Position: refs/heads/master@{#379503} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
