Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 { | 5 { |
| 6 'variables': { | 6 'variables': { |
| 7 'chromium_code': 1, | 7 'chromium_code': 1, |
| 8 }, | 8 }, |
| 9 'targets': [ | 9 'targets': [ |
| 10 { | 10 { |
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 76 ], | 76 ], |
| 77 ], | 77 ], |
| 78 }, # target_name: shell_dialogs | 78 }, # target_name: shell_dialogs |
| 79 { | 79 { |
| 80 # GN version: //ui/shell_dialogs:shell_dialogs_unittests | 80 # GN version: //ui/shell_dialogs:shell_dialogs_unittests |
| 81 'target_name': 'shell_dialogs_unittests', | 81 'target_name': 'shell_dialogs_unittests', |
| 82 'type': 'executable', | 82 'type': 'executable', |
| 83 'dependencies': [ | 83 'dependencies': [ |
| 84 '../../base/base.gyp:base', | 84 '../../base/base.gyp:base', |
| 85 '../../base/base.gyp:test_support_base', | 85 '../../base/base.gyp:test_support_base', |
| 86 '../../base/base.gyp:run_all_unittests', | |
| 87 '../../testing/gtest.gyp:gtest', | 86 '../../testing/gtest.gyp:gtest', |
| 88 'shell_dialogs', | 87 'shell_dialogs', |
| 89 ], | 88 ], |
| 90 'sources': [ | 89 'sources': [ |
| 91 # Note: file list duplicated in GN build. | 90 # Note: file list duplicated in GN build. |
| 91 '../../base/test/run_all_unittests.cc', | |
|
karandeepb
2016/03/04 04:08:27
It seems that targets without any sources cause li
Nico
2016/03/04 07:33:21
It is true that a target without any sources can c
karandeepb
2016/03/06 06:10:23
I have pasted the failing link line on the linked
| |
| 92 'select_file_dialog_win_unittest.cc', | 92 'select_file_dialog_win_unittest.cc', |
| 93 ], | 93 ], |
| 94 }, | 94 }, |
| 95 ], | 95 ], |
| 96 } | 96 } |
| OLD | NEW |