Make shell_dialogs_unittests link correctly on Non-Windows gyp builds.

ui/shell_dialogs/shell_dialogs.gyp

Index: ui/shell_dialogs/shell_dialogs.gyp
diff --git a/ui/shell_dialogs/shell_dialogs.gyp b/ui/shell_dialogs/shell_dialogs.gyp
index 2329f8fa19e4a03339146c26b2f853d6dab29fae..3250612e52079e90d8a3926c2355c7a88fe74a8a 100644
--- a/ui/shell_dialogs/shell_dialogs.gyp
+++ b/ui/shell_dialogs/shell_dialogs.gyp
@@ -83,12 +83,12 @@
       'dependencies': [
         '../../base/base.gyp:base',
         '../../base/base.gyp:test_support_base',
-        '../../base/base.gyp:run_all_unittests',
         '../../testing/gtest.gyp:gtest',
         'shell_dialogs',
       ],
       'sources': [
         # Note: file list duplicated in GN build.
+        '../../base/test/run_all_unittests.cc',

[karandeepb, 2016/03/04 04:08:27]

It seems that targets without any sources cause link errors with gyp. However,
gn does not seem to have this problem. Any insights?

[Nico, 2016/03/04 07:33:21]

It is true that a target without any sources can cause link errors with some of
gyp's generators. However, this target already has a source file – why this
change? What's the error message without this?

…oh, I see the bug you linked to answers this. Can you paste the link line
that's failing somewhere? It kind of looks like the executable is failing to
link to libc++?

[karandeepb, 2016/03/06 06:10:23]

I have pasted the failing link line on the linked bug report. This target has a
source file but it is only compiled and linked on Windows. This is the reason
why build succeeds on Windows but not on other platforms.

         'select_file_dialog_win_unittest.cc',
       ],
     },