Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h
index 0dced6e8d2fcdefc80b9f5e1a95b5b58e5d3971a..96007f74e15ca25dc20879d9139d9f0072330a54 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h
+++ b/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h
@@ -25,7 +25,7 @@
#ifndef RTCStatsRequestImpl_h
#define RTCStatsRequestImpl_h
-#include "core/dom/ContextLifecycleObserver.h"
+#include "core/dom/ActiveDOMObject.h"
#include "modules/mediastream/RTCStatsResponse.h"
#include "platform/heap/Handle.h"
#include "platform/mediastream/RTCStatsRequest.h"
@@ -38,7 +38,7 @@
class RTCPeerConnection;
class RTCStatsCallback;
-class RTCStatsRequestImpl final : public RTCStatsRequest, public ContextLifecycleObserver {
+class RTCStatsRequestImpl final : public RTCStatsRequest, public ActiveDOMObject {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCStatsRequestImpl);
public:
static RTCStatsRequestImpl* create(ExecutionContext*, RTCPeerConnection*, RTCStatsCallback*, MediaStreamTrack*);
@@ -50,7 +50,8 @@
void requestSucceeded(RTCStatsResponseBase*) override;
- void contextDestroyed() override;
+ // ActiveDOMObject
+ void stop() override;
DECLARE_VIRTUAL_TRACE();

Powered by Google App Engine
This is Rietveld 408576698