Issue 1758503002: Make the lock/unlock and Enter/Exit methods in Mutex and Monitor private so taht we always use the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1758503002: Make the lock/unlock and Enter/Exit methods in Mutex and Monitor private so taht we always use the … (Closed)

Created:
4 years, 9 months ago by siva

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make the lock/unlock and Enter/Exit methods in Mutex and Monitor private so taht we always use the locker objects for operating on mutexes/monitors. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/3067a27a8cb256e75325a3fc4942b98a78d70e76

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -81 lines)			Patch
M	runtime/vm/message_handler.h	View	1	4 chunks	+8 lines, -13 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View		9 chunks	+17 lines, -39 lines	0 comments	Download
M	runtime/vm/message_handler_test.cc	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/os_thread.h	View	1	4 chunks	+26 lines, -16 lines	0 comments	Download
M	runtime/vm/service.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/thread_interrupter.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 9 months ago (2016-03-02 17:20:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3067a27a8cb256e75325a3fc4942b98a78d70e76 (presubmit successful).