Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: runtime/vm/service.cc

Issue 1758503002: Make the lock/unlock and Enter/Exit methods in Mutex and Monitor private so taht we always use the … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review-comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/os_thread.h ('k') | runtime/vm/thread_interrupter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index b7ac72158c8937a420117ecc08ddea19b9d6a375..70e677a0df4befa7158c1e7f7e7de06b92ab103b 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1291,8 +1291,7 @@ static bool GetStack(Thread* thread, JSONStream* js) {
}
{
- MessageHandler::AcquiredQueues aq;
- isolate->message_handler()->AcquireQueues(&aq);
+ MessageHandler::AcquiredQueues aq(isolate->message_handler());
jsobj.AddProperty("messages", aq.queue());
}
@@ -1679,8 +1678,7 @@ static RawObject* LookupHeapObjectMessage(Thread* thread,
if (!GetUnsignedIntegerId(parts[1], &message_id, 16)) {
return Object::sentinel().raw();
}
- MessageHandler::AcquiredQueues aq;
- thread->isolate()->message_handler()->AcquireQueues(&aq);
+ MessageHandler::AcquiredQueues aq(thread->isolate()->message_handler());
Message* message = aq.queue()->FindMessageById(message_id);
if (message == NULL) {
// The user may try to load an expired message.
« no previous file with comments | « runtime/vm/os_thread.h ('k') | runtime/vm/thread_interrupter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698