Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: runtime/vm/thread_interrupter.cc

Issue 1758503002: Make the lock/unlock and Enter/Exit methods in Mutex and Monitor private so taht we always use the … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review-comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_interrupter.cc
diff --git a/runtime/vm/thread_interrupter.cc b/runtime/vm/thread_interrupter.cc
index e11770387d77cf06a3a959839f6185cfe49e073b..d87411aa1129942c7072156c8f7f8056aacd40e8 100644
--- a/runtime/vm/thread_interrupter.cc
+++ b/runtime/vm/thread_interrupter.cc
@@ -98,7 +98,7 @@ void ThreadInterrupter::Shutdown() {
}
shutdown_ = true;
// Notify.
- monitor_->Notify();
+ shutdown_ml.Notify();
ASSERT(initialized_);
if (FLAG_trace_thread_interrupter) {
OS::Print("ThreadInterrupter shutting down.\n");
@@ -183,7 +183,7 @@ void ThreadInterrupter::ThreadMain(uword parameters) {
interrupted_thread_count = 0;
// Temporarily drop the monitor while we interrupt threads.
- monitor_->Exit();
+ wait_ml.Exit();
{
OSThreadIterator it;
@@ -197,7 +197,7 @@ void ThreadInterrupter::ThreadMain(uword parameters) {
}
// Take the monitor lock again.
- monitor_->Enter();
+ wait_ml.Enter();
// Now that we have the lock, check if we were signaled to wake up while
// interrupting threads.
« no previous file with comments | « runtime/vm/service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698