Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-events_chromium.org, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. BUG=580337 Committed: https://crrev.com/76f48eb503c304f76dd0a988ccb5800490410c8c Cr-Commit-Position: refs/heads/master@{#379220}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : review comments addressed. #

Patch Set 5 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -259 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/scriptParsedHash.html View 1 2 3 4 1 chunk +17 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/scriptParsedHash-expected.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-operation-events.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-operation-events-expected.txt View 1 2 3 4 3 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Collections.h View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h View 1 2 1 chunk +195 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 1 2 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 1 2 5 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 2 chunks +1 line, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp View 1 5 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectorWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8AsyncCallTracker.cpp View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 6 chunks +11 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 3 16 chunks +31 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 1 5 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8JavaScriptCallFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8EventListenerInfo.h View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pfeldman
4 years, 9 months ago (2016-03-04 00:43:08 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp (right): https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp#newcode69 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp:69: m_nameToObjectGroup.get(groupName).append(objectId); Restore. https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (right): https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#newcode95 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:95: ...
4 years, 9 months ago (2016-03-04 02:44:05 UTC) #3
pfeldman
All done. https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp (right): https://codereview.chromium.org/1758313002/diff/40001/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp#newcode69 third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp:69: m_nameToObjectGroup.get(groupName).append(objectId); On 2016/03/04 02:44:05, dgozman wrote: > ...
4 years, 9 months ago (2016-03-04 02:51:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758313002/80001
4 years, 9 months ago (2016-03-04 03:03:44 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-04 05:57:48 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 05:59:16 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/76f48eb503c304f76dd0a988ccb5800490410c8c
Cr-Commit-Position: refs/heads/master@{#379220}

Powered by Google App Engine
This is Rietveld 408576698