third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

index 4fec247d8fd0c993af3f3dce3b30f11dc4ef5f14..15b16b58cd5419d4b8d0d0db481a010e92efe034 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

@@ -108,7 +108,7 @@ private:

// Each script inherits debug data from v8::Context where it has been compiled.

// Only scripts whose debug data matches |contextGroupId| will be reported.

// Passing 0 will result in reporting all scripts.

- void getCompiledScripts(int contextGroupId, Vector<V8DebuggerParsedScript>&);

+ void getCompiledScripts(int contextGroupId, protocol::Vector<V8DebuggerParsedScript>&);

V8DebuggerAgentImpl* getAgentForContext(v8::Local<v8::Context>);

void compileDebuggerScript();

@@ -132,7 +132,7 @@ private:

v8::Isolate* m_isolate;

V8DebuggerClient* m_client;

- using AgentsMap = HashMap<int, V8DebuggerAgentImpl*>;

+ using AgentsMap = protocol::HashMap<int, V8DebuggerAgentImpl*>;

AgentsMap m_agentsMap;

bool m_breakpointsActivated;

v8::Global<v8::FunctionTemplate> m_breakProgramCallbackTemplate;