Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version

Issue 1758313002: DevTools: introduce collections shim to be backed by non-wtf in v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version b/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
index d6ee227267c3e3730ff34c0c12e6b524a0d441f2..2054e1e5fab9b2a928b2fffe12152709032ebf67 100755
--- a/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
+++ b/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
@@ -435,7 +435,6 @@ def main():
#ifndef InspectorProtocolVersion_h
#define InspectorProtocolVersion_h
-#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -446,29 +445,10 @@ int inspectorProtocolVersionMajor() { return %s; }
int inspectorProtocolVersionMinor() { return %s; }
-bool supportsInspectorProtocolVersion(const String& version)
-{
- Vector<String> tokens;
- version.split(".", tokens);
- if (tokens.size() != 2)
- return false;
-
- bool ok = true;
- int major = tokens[0].toInt(&ok);
- if (!ok || major != %s)
- return false;
-
- int minor = tokens[1].toInt(&ok);
- if (!ok || minor > %s)
- return false;
-
- return true;
-}
-
}
#endif // !defined(InspectorProtocolVersion_h)
-""" % (version, major, minor, major, minor))
+""" % (version, major, minor))
output_file.close()

Powered by Google App Engine
This is Rietveld 408576698