Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1758003003: [turbofan] ARM: Reduce out-of-line NaN code size (Closed)

Created:
4 years, 9 months ago by martyn.capewell
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM: Reduce out-of-line NaN code size Reduce the amount of code generated for OutOfLineLoadFloat* by computing sqrt(-1) rather than move the NaN as an immediate. Add support for single precision floating point immediate moves to enable this. BUG= Committed: https://crrev.com/2cd9877b6d5e299c21dd867cb0d519183d4bc7bd Cr-Commit-Position: refs/heads/master@{#34746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -15 lines) Patch
M src/arm/assembler-arm.cc View 5 chunks +23 lines, -10 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
martyn.capewell
Although the replacement code to generate a NaN is slower, I can detect no significant ...
4 years, 9 months ago (2016-03-03 11:27:27 UTC) #3
martyn.capewell
Ping?
4 years, 9 months ago (2016-03-14 10:47:48 UTC) #4
Benedikt Meurer
LGTM.
4 years, 9 months ago (2016-03-14 11:09:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758003003/1
4 years, 9 months ago (2016-03-14 14:42:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 15:30:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 15:31:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cd9877b6d5e299c21dd867cb0d519183d4bc7bd
Cr-Commit-Position: refs/heads/master@{#34746}

Powered by Google App Engine
This is Rietveld 408576698