Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1757253002: Revert "Pull and build shaderc rather than use checked in lib/header" (Closed)

Created:
4 years, 9 months ago by borenet
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Pull and build shaderc rather than use checked in lib/header" This reverts commit 7d4490ecfa4d974003f675ef004e77f85ecfadd2. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757253002 Committed: https://skia.googlesource.com/skia/+/b5f0d40935feba474852c61622ee6fcb1db3727c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -157 lines) Patch
M DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/gpu.gyp View 6 chunks +7 lines, -7 lines 0 comments Download
D gyp/shaderc.gyp View 1 chunk +0 lines, -63 lines 0 comments Download
A third_party/shaderc/Debug/shaderc_combined.lib View Binary file 0 comments Download
A third_party/shaderc/Release/shaderc_combined.lib View Binary file 0 comments Download
A third_party/shaderc/shaderc.h View 1 chunk +321 lines, -0 lines 0 comments Download
D tools/build_shaderc.py View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
borenet
4 years, 9 months ago (2016-03-03 13:01:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5f0d40935feba474852c61622ee6fcb1db3727c.

Powered by Google App Engine
This is Rietveld 408576698