Stop dispatching notifyFinished for each part in a multipart response

Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
Committed: https://crrev.com/a548e7c490465d9c16e7697b3aaebb362ae55fce
Cr-Commit-Position: refs/heads/master@{#381920}

[yhirano, 2016-03-02 18:13:21]

Description was changed from

==========
Stop dispatching multiple notifyFinished for a multipart response

This change stops dispatching multiple notifyFinished for a multipart response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
==========

to

==========
Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart
response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
==========

[yhirano, 2016-03-02 18:13:42]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-03-02 20:23:31]

yhirano@chromium.org changed reviewers:
+ japhet@chromium.org

[yhirano, 2016-03-02 20:23:32]

This CL depends on https://codereview.chromium.org/1710733002/.

[yhirano, 2016-03-14 07:32:10]

ping

[Nate Chapin, 2016-03-15 21:31:12]

LGTM with a nit:

https://codereview.chromium.org/1756953002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ImageResource.h (right):

https://codereview.chromium.org/1756953002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ImageResource.h:160: int
m_numParsedPartsInMultipart = 0;
Maybe this should be a state machine enum, since we don't care once we reach 2?
e.g.

enum MultipartResponseState {
    WaitingForResponse,
    FirstPartReceived,
    PayloadReceived
};

[hiroshige, 2016-03-15 21:38:36]

hiroshige@chromium.org changed reviewers:
+ hiroshige@chromium.org

[hiroshige, 2016-03-15 21:38:37]

https://codereview.chromium.org/1756953002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ImageResource.cpp (right):

https://codereview.chromium.org/1756953002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ImageResource.cpp:478: clear();
nit: this CL removes |if (m_data)| check. Is this intentional?

[hiroshige, 2016-03-15 23:19:34]

I found a behavior change by this CL and uploaded a draft CL [1] (see the
description what occurs).

Currently, due to subtle behavior of (3)/(4), window.stop() stops loading of
multipart images for the most of the time (i.e. except for after onload and
before next part is received).
This CL will supress step (3)/(4) described in [1], and thus window.stop()
cannot stop loading of multipart images after onload, e.g.
stop-loading-after-onload2.html in [1] passes on ToT but fails with this CL.

[1] fixes this by keeping the ResourceLoader in m_nonBlockingLoaders and after
[1] stop-loading-after-onload2.html passes with this CL.

[1] https://codereview.chromium.org/1800333003/

[hiroshige, 2016-03-17 02:08:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 02:09:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756953002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756953002/100001

[commit-bot: I haz the power, 2016-03-17 02:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:49:57]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-17 02:56:19]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 02:56:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756953002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756953002/100001

[commit-bot: I haz the power, 2016-03-17 03:01:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 03:01:51]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-03-18 04:14:25]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-03-18 04:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1756953002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-03-18 04:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756953002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756953002/100001

[commit-bot: I haz the power, 2016-03-18 06:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 06:55:27]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-03-18 08:29:01]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-03-18 08:29:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1756953002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1756953002/100001

[commit-bot: I haz the power, 2016-03-18 09:43:15]

Description was changed from

==========
Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart
response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
==========

to

==========
Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart
response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
==========

[commit-bot: I haz the power, 2016-03-18 09:43:16]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-03-18 09:44:38]

Description was changed from

==========
Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart
response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608
==========

to

==========
Stop dispatching notifyFinished for each part in a multipart response

This change stops dispatching notifyFinished for each part in a multipart
response.
Instead, it's dispatched when the second part begins (i.e. the first part ends).

BUG=570608

Committed: https://crrev.com/a548e7c490465d9c16e7697b3aaebb362ae55fce
Cr-Commit-Position: refs/heads/master@{#381920}
==========

[commit-bot: I haz the power, 2016-03-18 09:44:40]

Patchset 5 (id:??) landed as
https://crrev.com/a548e7c490465d9c16e7697b3aaebb362ae55fce
Cr-Commit-Position: refs/heads/master@{#381920}