Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp

Issue 1756953002: Stop dispatching notifyFinished for each part in a multipart response (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup-2
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
index 184e9de494a24d6e873f6b2b1d823931c829a767..bf4a564bbd7050ba95927c8d63a4ecba198782c7 100644
--- a/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
@@ -29,11 +29,8 @@ class MockClient final : public NoBaseWillBeGarbageCollectedFinalized<MockClient
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MockClient);
public:
- void onePartInMultipartReceived(const ResourceResponse& response, bool isFirstPart) override
+ void onePartInMultipartReceived(const ResourceResponse& response) override
{
- if (isFirstPart != m_responses.isEmpty())
- FAIL() << "m_responses.size() = " << m_responses.size() << ", isFirstPart = " << isFirstPart;
-
m_responses.append(response);
m_data.append(Vector<char>());
}
@@ -445,37 +442,6 @@ TEST(MultipartResponseTest, MultipleBoundaries)
EXPECT_EQ("foofoo", toString(client->m_data[1]));
}
-TEST(MultipartResponseTest, IsFirstPartSet)
-{
- ResourceResponse response;
- response.setMimeType("multipart/x-mixed-replace");
- MockClient* client = new MockClient;
- Vector<char> boundary;
- boundary.append("bound", 5);
-
- MultipartImageResourceParser* parser = new MultipartImageResourceParser(response, boundary, client);
-
- // isFirstPart is checked at MockClient::didReceiveResponse.
- const char data[] =
- "--bound\n"
- "Content-type: text/plain\n\n"
- "response data\n"
- "--bound\n";
- parser->appendData(data, strlen(data));
- ASSERT_EQ(1u, client->m_responses.size());
- ASSERT_EQ(1u, client->m_data.size());
- EXPECT_EQ("response data", toString(client->m_data[0]));
-
- const char data2[] =
- "Content-type: text/plain\n\n"
- "response data2\n"
- "--bound\n";
- parser->appendData(data2, strlen(data2));
- ASSERT_EQ(2u, client->m_responses.size());
- ASSERT_EQ(2u, client->m_data.size());
- EXPECT_EQ("response data2", toString(client->m_data[1]));
-}
-
} // namespace
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698