Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1808353003: Make multipart/x-mixed-replace parser more robust (Closed)

Created:
4 years, 9 months ago by yhirano
Modified:
4 years, 9 months ago
Reviewers:
hiroshige, Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@multipart-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make multipart/x-mixed-replace parser more robust 1. The parser eats leading CR, LF, CRLF and LFLF. It would be better to eat only LF and CRLF, as other parts such as net::HttpUtil::LocateEndOfHeaders does the same thing. 2. The parser eats leading EOLs repeatedly. For example, it eats "\n" when "\n\nfoo" is given, but it eats "\n" twice when "\n" is given and then "\nfoo" is given. 3. The parser sends the remainder inputs to the client as body data if it is parsing body and the input ends with LF, although the parser might be ought to ignore that LF in the future if it's the end-of-body. BUG=570608 Committed: https://crrev.com/16099ee7cc1e68d6ffea2b50d4faa1763e33a6af Cr-Commit-Position: refs/heads/master@{#382790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -48 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MultipartImageResourceParser.cpp View 6 chunks +22 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp View 7 chunks +71 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
yhirano
4 years, 9 months ago (2016-03-18 08:26:40 UTC) #5
Nate Chapin
lgtm
4 years, 9 months ago (2016-03-18 19:45:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808353003/1
4 years, 9 months ago (2016-03-23 01:41:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 04:22:00 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 04:23:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16099ee7cc1e68d6ffea2b50d4faa1763e33a6af
Cr-Commit-Position: refs/heads/master@{#382790}

Powered by Google App Engine
This is Rietveld 408576698