test/cctest/test-disasm-ia32.cc - Issue 1756863002: [wasm] Int64Lowering of I64Shl on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-disasm-ia32.cc

Issue 1756863002: [wasm] Int64Lowering of I64Shl on ia32. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Forgot to turn off the test for arm. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-disasm-ia32.cc

diff --git a/test/cctest/test-disasm-ia32.cc b/test/cctest/test-disasm-ia32.cc

index 669e37ac69bff2b8a3a2b5347b5ccbacd4602474..de8854b8524df103f89c44976a47512587b48866 100644

--- a/test/cctest/test-disasm-ia32.cc

+++ b/test/cctest/test-disasm-ia32.cc

@@ -119,7 +119,8 @@ TEST(DisasmIa320) {

__ nop();

__ imul(edx, ecx);

- __ shld(edx, ecx);

+ __ shld(edx, ecx, 10);

+ __ shld_cl(edx, ecx);

__ shrd(edx, ecx);

__ bts(edx, ecx);

__ bts(Operand(ebx, ecx, times_4, 0), ecx);

@@ -214,7 +215,6 @@ TEST(DisasmIa320) {

__ sar(Operand(ebx, ecx, times_4, 10000), 6);

__ sar_cl(Operand(ebx, ecx, times_4, 10000));

__ sbb(edx, Operand(ebx, ecx, times_4, 10000));

- __ shld(edx, Operand(ebx, ecx, times_4, 10000));

__ shl(edx, 1);

__ shl(edx, 6);

__ shl_cl(edx);

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | test/cctest/wasm/test-run-wasm-64.cc » ('j') | no next file with comments »