Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1735033004: Bindings and client interface for the IsAppInstalled API. (Closed)

Created:
4 years, 10 months ago by Daniel Nishi
Modified:
4 years, 5 months ago
Reviewers:
haraken, benwells, dcheng
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IsAppInstalled bindings and interface. This is part 1 of a multipart change set to add IsAppInstalled bindings to Blink. A later part will add the content/ side of the patch and layout tests once the implementation is landed. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0xXsJYdkaWg Explainer: https://github.com/DHNishi/IsNativeAppInstalled/blob/master/explainer.md BUG=587623 Committed: https://crrev.com/6259e2ce653d05821a1a42784bde6a1ba946e564 Cr-Commit-Position: refs/heads/master@{#379891}

Patch Set 1 #

Patch Set 2 : Add OWNERS., #

Total comments: 16

Patch Set 3 : #

Total comments: 20

Patch Set 4 : #

Patch Set 5 : Rebase. #

Patch Set 6 : Fix a few layout tests #

Patch Set 7 : Try fix tests one last time. #

Patch Set 8 : Fix Oilpan compile. #

Patch Set 9 : Fix layout tests for real. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/InstalledAppController.h View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h View 1 2 3 4 5 6 7 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 2 3 4 5 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/RelatedApplication.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/installedapp/RelatedApplication.idl View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 8 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/installedapp/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/installedapp/WebInstalledAppClient.h View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/installedapp/WebRelatedApplication.h View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (11 generated)
Daniel Nishi
haraken@chromium.org: Please review changes in third_party/WebKit/Source/modules/*, third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in, third_party/WebKit/Source/web/WebLocalFrameImpl.cpp, and the layout test. dcheng@chromium.org: Please review ...
4 years, 10 months ago (2016-02-26 22:50:29 UTC) #4
haraken
https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp File third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp (right): https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp#newcode22 third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp:22: WillBeHeapSupplement<LocalFrame>::provideTo(frame, supplementName(), adoptPtrWillBeNoop(controller)); OwnPtr<InstalledAppController> controllers = adoptPtr(new ...); provideTo(..., ...
4 years, 9 months ago (2016-02-27 15:53:12 UTC) #5
dcheng
https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp File third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp (right): https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp#newcode58 third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp:58: HeapVector<Member<RelatedApplication>> applications; What's the benefit to using a heap ...
4 years, 9 months ago (2016-02-27 18:30:37 UTC) #6
Daniel Nishi
Thanks! Please take another look when you get a chance. https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp File third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp (right): https://codereview.chromium.org/1735033004/diff/40001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp#newcode22 ...
4 years, 9 months ago (2016-02-29 18:38:39 UTC) #7
haraken
LGTM https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp File third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp (right): https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp#newcode47 third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp:47: callback.release()->onError(); callback->onError() https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl File third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl (right): https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl#newcode5 third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl:5: ...
4 years, 9 months ago (2016-03-01 02:15:26 UTC) #8
dcheng
https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h File third_party/WebKit/Source/modules/installedapp/InstalledAppController.h (right): https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h#newcode21 third_party/WebKit/Source/modules/installedapp/InstalledAppController.h:21: Nit: no newline before public: (here and elsewhere) https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp ...
4 years, 9 months ago (2016-03-01 20:03:04 UTC) #9
Daniel Nishi
Thanks again to you two. dcheng: Please take another look when you get a chance. ...
4 years, 9 months ago (2016-03-01 20:46:20 UTC) #11
dcheng
lgtm https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/public/platform/modules/installedapp/WebInstalledApp.h File third_party/WebKit/public/platform/modules/installedapp/WebInstalledApp.h (right): https://codereview.chromium.org/1735033004/diff/60001/third_party/WebKit/public/platform/modules/installedapp/WebInstalledApp.h#newcode15 third_party/WebKit/public/platform/modules/installedapp/WebInstalledApp.h:15: using AppInstalledCallbacks = WebCallbacks<WebPassOwnPtr<WebVector<WebRelatedApplication>>, void>; On 2016/03/01 at ...
4 years, 9 months ago (2016-03-01 22:03:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735033004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735033004/200001
4 years, 9 months ago (2016-03-08 18:04:47 UTC) #17
commit-bot: I haz the power
Committed patchset #9 (id:200001)
4 years, 9 months ago (2016-03-08 19:49:43 UTC) #19
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/6259e2ce653d05821a1a42784bde6a1ba946e564 Cr-Commit-Position: refs/heads/master@{#379891}
4 years, 9 months ago (2016-03-08 19:50:28 UTC) #21
haraken
It looks like that the content-side implementation of installedAppClient is not yet landed. Are you ...
4 years, 5 months ago (2016-07-06 09:08:01 UTC) #22
Daniel Nishi
On 2016/07/06 09:08:01, haraken wrote: > It looks like that the content-side implementation of installedAppClient ...
4 years, 5 months ago (2016-07-06 16:33:27 UTC) #23
haraken
+benwells Are you actively working on this feature? (See #22 for more contexts)
4 years, 5 months ago (2016-07-07 00:08:54 UTC) #25
benwells
4 years, 5 months ago (2016-07-17 22:08:01 UTC) #26
Message was sent while issue was closed.
On 2016/07/07 00:08:54, haraken wrote:
> +benwells
> 
> Are you actively working on this feature? (See #22 for more contexts)

Yes, it's in my list of things to do and still relevant from a product
perspective. My next step was to raise with the wicg and get a feel for the
reactions there.

Powered by Google App Engine
This is Rietveld 408576698